I got all my pending code reviewed and commited the changes to my repo after resolving issues. The patch had to go through a number of interations to resolve the issues in prior patches. The last patch fixed all the major bugs.
Ah! This week was a bit hectic. But I was able to do considerable amount of work.
As I mentioned in my previous post I ported modernized
stylus theme to
bootstrap by making changes in
Global Tempates. But Roger Haase suggested to make exlusive templates for Bootstrap themes as making changes to
Global templates would restrict all the other theme developers to use Bootstrap's components such as
panel.. etc. I also made changes in Global Templates to make sure that it doesn't conflict with any bootstrap theme that work on top of it.
Show me the code!
# ChangeLog from patch #2
Fixed the alignment of sub menu tabs and item views tabs
Added active visual effect to the current tab view
Fixed horizontal scroll bug
Fixed padding inside sub menu
Increased font size for wiki contents
Automation + Global History
# Changelog 3 , new cr patch 1
Added automation. run
$ ./m css to automatically compile all the less files.
Modernized theme now runs with the current version of xstatic bootstrap.
global history template
Changed font sizes at various places
Made changes as suggested in last CR
Created a special directory exclusively for modernized theme's template.
Added footer and breadcrumb.
Made changes as suggested by mentors in previous patch
Some of the bugs in previous CRs were:
HTML validation error due to use of form inside ul and unclosed div tags.This is fixed in my last commit.
Design break issues in mobile views. Fixed in commit:
Design break issue when breadcrumb's patch is too large. Fixed in this commit.
Changes in User Setting and common.js to support highlighting of current links in menu # Added common.css # Current opened tab now highlights in menu # Various css rules written to work on top/with common.css # Fixed the issue 'jumping of footer while changing tabs in user setting' # Fixed issue with breadcrumbs when the location address gets too long. # Fixed all the HTML error validation errors
The issues with last CR's were discussed with mentors and fixed.
Quick summary of my commits:
I actually made a new branch in my fork of repo called
improvethemes. Since I am doing things step by step and some things get broken in intermediatlry stages, It wouldn't have been right to commit changes in main branch. This can be easily merged when this feature is working 100% without any bugs.
Now back to summary:
I have made 3 commits as yet , 4th one with improvements in usersetting page is exptected soon :).
Commit #1 : Created a new branch
Commit #2 : Wrote a new modernized theme based on bootstrap and also made it's template files (layout.html, global_history.html)
The template contains all the basic components such as navbar,sub menu, item menu, breadcrumb, footer.. etc.
Commit #3 :
Further improvements in modernized theme and few style fixes in basic theme
Improvements in modernized theme:# Added common.css
Current opened tab now highlights in menu
Various css rules written to work on top/with common.css
Fixed the issue 'jumping of footer while changing tabs in user setting'
Fixed issue with breadcrumbs when the location address gets too long.
Fixed footer jump while changing tabs in user setting in basic theme
Fixed design break issue in Basic theme's subscription box: http://i.imgur.com/4s1CIb3.png
Fixed design break in small resolution and removed form from under 'ul'
Commit #4: Fixed HTML validation error due to unclosed div tag
I also updated xstatic bootstrap here is the commmit.
This updates Bootstrap to version : 3.3.5
Show me the screenshots!!
Other Updates ?
Yea! I participated in continuous 34 hours AngelHack Hackathon this week. It was a greeat experience and we made an opensource chat summarizer tool. I am really proud of this app. We worked together all night all day! It was a great experience. Well done Vinayak Mehta, Ketan bhutt , Pranu!.
About this app:
Summarize it is a chat summarizer plugin for instant messaging applications. It summarizes the large content of chat logs which enables users to quickly understand the current context of the conversation. Currently Summarize it works on top of Slack as its plugin.
One last thing...!
I have started teaching Django web developement to college students as a part of their summer training. First class was on tuesday which was an introductory class. All of the students are enthusiastic! I really like Django and this is going to be a great experiance.